Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colour Space values #337

Open
gibix opened this issue Aug 10, 2019 · 4 comments
Open

Colour Space values #337

gibix opened this issue Aug 10, 2019 · 4 comments
Labels
clarifications spec_codecs Codec Matroska spec document target

Comments

@gibix
Copy link

gibix commented Aug 10, 2019

I want to parse \Segment\Tracks\TrackEntry\Video\ColourSpace and is not clear to me witch are all the possible values to handle by a complete mkv demuxer.

@dericed
Copy link
Contributor

dericed commented Aug 12, 2019

I'm interested in making the description more specific to recommend an external authority or to possible list a set as should-be-supported; however at the moment I think the intent is that this field is intended to store the fourcc for uncompressed video as it would be in avi and I'm not sure if there is a decent authority list of those fourccs to cite.

@robUx4 robUx4 added clarifications spec_codecs Codec Matroska spec document target labels Aug 13, 2019
@lu-zero
Copy link
Contributor

lu-zero commented Aug 13, 2019

The AVI fourccs would clash with the Colour description, I'd deprecate the use (since the current description of the field does not even say that the AVI ones are supported).

Talking with @robUx4 I'll prepare a pull request to have a mapping for:

  • RGB,
  • YCbCr
  • YCoCg,
  • ICtCp,
  • XYZ
  • CMYK
  • HSV
  • LAB

Expressed as 'M','0', '0', {numeric value matching the list order}.

The Colour should contain all the other useful information.

@kodawah
Copy link

kodawah commented Aug 13, 2019

I think ColourSpace is poorly named and mostly refers to how data is packed when it is RAW: for example it defines VYUY, and 2YUY which are packing modes, not related to color systems (which is what @lu-zero is referring to) or color spaces (which is what @dericed is referring to i think)

having a ColorSystem entity would be nice, I'm unsure of the usefulness of this ColourSpace entity

@robUx4 robUx4 added spec_main Main Matroska spec document target and removed spec_codecs Codec Matroska spec document target labels Mar 14, 2021
@robUx4
Copy link
Contributor

robUx4 commented Aug 26, 2021

#548 should not close this, the clarifications should be done properly in the codec spec, not the main format spec. It's specific to one codec: V_UNCOMPRESSED.

@robUx4 robUx4 added spec_codecs Codec Matroska spec document target and removed spec_main Main Matroska spec document target labels Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarifications spec_codecs Codec Matroska spec document target
Projects
None yet
Development

No branches or pull requests

5 participants