Problem with num iterations in Dr16FixedEtaVarlssFudgeExpectedFlux

[cramirezpe]

Since default values cannot be changed by a child class (line 328):

picca/py/picca/delta_extraction/utils.py

Lines 302 to 336 in 3d5e508

	def update_default_options(default_options, new_options):
	"""Update the content of the list of accepted options
	Arguments
	---------
	default_options: dict
	The current default options
	new_options: dict
	The new options
	Return
	------
	default_options: dict
	The updated default options
	"""
	default_options = default_options.copy()
	for key, value in new_options.items():
	if key in default_options:
	default_value = default_options.get(key)
	if type(default_value) is not type(value):
	raise DeltaExtractionError(
	f"Incompatible defaults are being added. Key {key} "
	"found to have values with different type: "
	f"{type(default_value)} and {type(value)}. "
	"Revise your recent changes or contact picca developpers.")
	if default_value != value:
	raise DeltaExtractionError(
	f"Incompatible defaults are being added. Key {key} "
	f"found to have two default values: '{value}' and '{default_value}' "
	"Revise your recent changes or contact picca developpers.")
	else:
	default_options[key] = value
	return default_options

This means that:

picca/py/picca/delta_extraction/expected_fluxes/dr16_fixed_eta_varlss_fudge_expected_flux.py

Lines 26 to 28 in 3d5e508

	defaults = update_default_options(defaults, {
	"num iterations": 1,
	})

Will always fail with the error:

picca.delta_extraction.errors.DeltaExtractionError: Incompatible defaults are being added. Key num iterations found to have two default values: '1' and '5' Revise your recent changes or contact picca developpers.

Because the Dr16ExpectedFlux sets "num iterations"=5.

[iprafols]

I added a quick fix to this issue in PR #986 @cramirezpe please let me know if you are happy with the fix