-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
network init
: Verify no gentx are present in the initial genesis
#2044
Comments
@lubtd @fadeev, thinking about the Crescent example, are you sure that we want to have this kind of a behavior? |
This behavior certainly requires everyone to use the Ignite CLI to apply to become a validator, but I don't see this as being particularly problematic. |
This is a strict requirement for Incentivized Testnets otherwise IBC connection for monitoring can be impossible or can be gamed. I specified in Genesis Generation Specification that it is a requirement for Incentivized Testnet. But there is no issue for other chains as long as the validators have the balances It's possible I didn't make the precision in the issue for simplicity but if there is usage where validators are directly in the custom genesis then it's a behavior that we could authorize for non-incentivized chains |
Then let's make it strict now by requiring no gentxs as proposed and if there is use case for the other scenario we can introduce it later. |
The validator can also send the gentx to the coordinator and the coordinator add the gentx. The sender of the request doesn't need to be the validator |
Is your feature request related to a problem? Please describe.
Gentx must be forbidden in the initial genesis of the chain (given from URL for example). All the validators of the chain must go through the request for Genesis Validator because the on-chain data like consensus public key and self delegation are used to enable a verified IBC connection
Describe the solution you'd like
The initial genesis is generated from the
initGenesis
method innetworkchain
.checkGenesis
verify that thevalidator-genesis
command passes. We must add the check that no gentx is present in the initial genesisThe text was updated successfully, but these errors were encountered: