Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing include to Graph.hh #342

Merged
merged 1 commit into from
Dec 27, 2021
Merged

Add missing include to Graph.hh #342

merged 1 commit into from
Dec 27, 2021

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

This was causing SDFormat to compile locally for me, using gazebosim/sdformat#803

/home/chapulina/dev_focal/ws_garden/install/include/ignition/math7/ignition/math/graph/Graph.hh: In constructor _ignition::math::v7::graph::
Graph<V, E, EdgeType>::Graph(const std::vector<ignition::math::v7::graph::Vertex<V> >&, const std::vector<ignition::math::v7::graph::EdgeInitializer<E> >&)_:                                                                                                                           
/home/chapulina/dev_focal/ws_garden/install/include/ignition/math7/ignition/math/graph/Graph.hh:118:16: error: _cerr_ is not a member of _std_                                                                                                                                          
  118 |           std::cerr << "Invalid vertex with Id [" << v.Id() << "]. Ignoring."                                                       
      |                ^~~~                                                                                                                 
/home/chapulina/dev_focal/ws_garden/install/include/ignition/math7/ignition/math/graph/Graph.hh:29:1: note: _std::cerr_ is defined in header
 _<iostream>_; did you forget to _#include <iostream>_?                                                                                     
   28 | #include <ignition/math/config.hh>                                                                                                  
  +++ |+#include <iostream>                                                                                                                 
   29 | #include "ignition/math/graph/Edge.hh"  

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina changed the title Add missing include Add missing include to Graph.hh Dec 27, 2021
@codecov
Copy link

codecov bot commented Dec 27, 2021

Codecov Report

Merging #342 (3290815) into main (132b0e4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #342   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files          67       67           
  Lines        6077     6077           
=======================================
  Hits         6033     6033           
  Misses         44       44           
Impacted Files Coverage Δ
include/ignition/math/graph/Graph.hh 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 132b0e4...3290815. Read the comment docs.

@chapulina chapulina merged commit 04a4c85 into main Dec 27, 2021
@chapulina chapulina deleted the chapulina/7/iostream branch December 27, 2021 19:20
akshatpandya pushed a commit to akshatpandya/ign-math that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants