Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package objects break property references #186

Open
sloshy opened this issue Nov 1, 2017 · 3 comments
Open

Package objects break property references #186

sloshy opened this issue Nov 1, 2017 · 3 comments

Comments

@sloshy
Copy link

sloshy commented Nov 1, 2017

I have a case class in my Play app called Movies. Movies has an item editions which is of type Seq[MovieEdition]. With the classes in the file models/Output.scala with the package models.output, the swagger JSON is generated properly including all types (/definitions/models.output.MovieEdition as expected) and property type references resolve as expected. Since moving the case classes to a package object, I get the following error when opening my swagger.json file:

Resolver error at paths./movies.get.responses.200.schema.properties.editions.items.$ref
Could not resolve reference because of: Could not resolve pointer: /definitions/models.output.package.MovieEdition does not exist in document

The case classes are located in a file models/output/package.scala with the package models.output. The model types are generated just fine in the swagger.json file, but the references mistakenly assume that the name includes .package as part of the package name.

@senegalo
Copy link

Same exact issue for me as well !

@alexmnyc
Copy link

same here

@Javakky-pxv
Copy link
Collaborator

@sloshy @senegalo @alexmnyc
We are currently reviewing it. It may take some time, but we plan to address it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants