Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Westeros tutorials inconsistent with changes made to baseline #624

Open
5 tasks done
OFR-IIASA opened this issue Jun 8, 2022 · 4 comments · May be fixed by #625
Open
5 tasks done

Westeros tutorials inconsistent with changes made to baseline #624

OFR-IIASA opened this issue Jun 8, 2022 · 4 comments · May be fixed by #625
Assignees
Labels
bug Doesn't work as advertised/unintended effects
Milestone

Comments

@OFR-IIASA
Copy link
Contributor

OFR-IIASA commented Jun 8, 2022

Recent changes to the Westeros baseline scenario have resulted in inconsistencies with scenarios building off of the baseline:

  • westeros baseline:

  • westeros_historical_new_capacity.ipynb

    • Change baseyear demand = 100GWa
    • Change text above the definition of demand to match
    • Remove FOM cost to comparison of gas_ppl and coal_ppl - for demonstration purposes.
    • Adapt "i.e. as we haven't defined fixed operating and maintenance costs."
@OFR-IIASA OFR-IIASA added the bug Doesn't work as advertised/unintended effects label Jun 8, 2022
@OFR-IIASA OFR-IIASA added this to the 3.6 milestone Jun 8, 2022
@OFR-IIASA OFR-IIASA changed the title Westeros tutorials inconsistent with cahnges made to baseline Westeros tutorials inconsistent with changes made to baseline Jun 8, 2022
@OFR-IIASA OFR-IIASA linked a pull request Jun 8, 2022 that will close this issue
4 tasks
@OFR-IIASA OFR-IIASA linked a pull request Jun 8, 2022 that will close this issue
4 tasks
@khaeru khaeru modified the milestones: 3.6, 3.7 Aug 17, 2022
@glatterf42 glatterf42 modified the milestones: 3.7, 3.8 Apr 20, 2023
@glatterf42
Copy link
Member

Shifted due to prioritization of ENGAGE baseline unit issue.

@glatterf42
Copy link
Member

As noted by @khaeru on Slack,

Both the coffee machine and Westeros baseline tutorials are using from message_ix.util import make_df. This function is provided at the top level; we can show instead from message_ix import make_df.

Whenever we get around to overhauling the tutorials, this should be included.

@glatterf42 glatterf42 modified the milestones: 3.8, 3.9 Dec 6, 2023
@glatterf42
Copy link
Member

Postponed due to lack of capacity/urgency.

@khaeru
Copy link
Member

khaeru commented Feb 15, 2024

Another thing that I think could be improved here:

  • Many of the tutorials have a "dependency" on westeros_baseline.ipynb, in the sense that the user must first run through that tutorial in order to have the baseline scenario in their local database expected by a second tutorial.
  • This both:
    • Increases friction to jump directly in to particular topics (if the user wants to do that, and we want to support it).
    • Complicates testing, as we have to be sure to always run westeros_baseline.ipynb first and ensure its output is present.
  • We already have message_ix.testing.make_westeros() that does (and should always) produce the same scenario as the baseline tutorial.
  • So, I would suggest we could add 1 cell at the top of many tutorials like:
    if westeros_baseline_is_not_present:
        make_westeros(mp, ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Doesn't work as advertised/unintended effects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants