Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move ilastik up in the plugins menu #60

Open
k-dominik opened this issue Jul 28, 2020 · 3 comments
Open

move ilastik up in the plugins menu #60

k-dominik opened this issue Jul 28, 2020 · 3 comments

Comments

@k-dominik
Copy link
Contributor

@emilmelnikov mentioned that it's because we're lower-case with our plugin name.

@imagejan
Copy link
Contributor

I think the issue is not only lower-case vs. upper-case. In addition, SciJava Commands have a default menu weight of POSITIVE_INFINITY.

See also imagej/imagej-legacy#179.

Instead of:

@Plugin(type = Command.class, headless = true, menuPath = "Plugins>ilastik>Import HDF5")

you can use something like:

@Plugin(type = Command.class, headless = true, menu = {
	@Menu(label = MenuConstants.PLUGINS_LABEL, MenuConstants.PLUGINS_WEIGHT, mnemonic = MenuConstants.PLUGINS_MNEMONIC),
	@Menu(label = "ilastik", weight = YOUR_ILASTIK_MENU_WEIGHT_CONSTANT),
	@Menu(label = "Import", weight = YOUR_DESIRED_POSITION_IN_SUBMENU)})

See https://github.com/imagej/op-finder/blob/e69c0613395b6398085fad09e1e227e10b1a4f8c/src/main/java/net/imagej/ui/swing/ops/FindOps.java#L38-L42 for an example.

@emilmelnikov
Copy link
Member

Is it a good ecosystem behavior to change plugin priority like that? It's not like our plugin is more important than other plugins installed in a system...

@k-dominik
Copy link
Contributor Author

Hey @imagejan,

thank you very much for the insight! Really cool that you keep an eye on this repo 👍

As for the menu weight I'd also be concerned on what the etiquette on these things is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants