Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mistral + chatml prompts #1426

Merged
merged 24 commits into from
Jan 16, 2024
Merged

add mistral + chatml prompts #1426

merged 24 commits into from
Jan 16, 2024
+107 −5

Conversation

cognitivetech
Copy link
Contributor

@cognitivetech cognitivetech commented Dec 19, 2023 •
edited
Loading

this adds what I believe is the correct prompt formatting for Mistral.. based on testing where I've rated it best vs llama-index and llama2

louis-jaris
louis-jaris reviewed Dec 19, 2023
View reviewed changes
Copy link
Contributor

@louis-jaris louis-jaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are missing -- they will help maintainers to review the difference between llama2 and mistral prompt format.

cognitivetech added 2 commits December 19, 2023 19:43
add mistral prompt template
bef698c
correct tests for mistral
b9a10b8 
test should always include system prompt..
@cognitivetech
Copy link
Contributor Author

cognitivetech commented Dec 20, 2023 •
edited
Loading

I added the system prompt to the expected test output, and removed def test_mistral_prompt_style_with_system_prompt(): because there aren't two expected behaviors. a given prompt method should always add the system prompt.

Maybe I'm missing something entirely

@cognitivetech
Copy link
Contributor Author

ok, now I'm seeing the discussion where system prompt is only set for Gradio users #1353

annnd, now I see in the api documentation where I can set system prompt as part of my api call 😮‍💨

okok... now I'm getting closer 😅 but .... at least I understand my confusion from before.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2024

Stale pull request

@github-actions github-actions bot added the stale label Jan 6, 2024
@cognitivetech cognitivetech changed the title add mistral prompt add mistral + chatml prompts Jan 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

Published docs preview URL: https://privategpt-preview-0390f24b-843c-46bd-907c-5840ec8af9c6.docs.buildwithfern.com

@github-actions GitHub Actions
Copy link
Contributor

Published docs preview URL: https://privategpt-preview-36dff305-9e9f-498f-9a42-b24e09368eec.docs.buildwithfern.com

@github-actions GitHub Actions
Copy link
Contributor

Published docs preview URL: https://privategpt-preview-1f058881-2111-4eb8-bf2c-b8166e9a83dd.docs.buildwithfern.com

imartinez
imartinez approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@imartinez imartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 😍

@imartinez imartinez merged commit e326126 into zylon-ai:main Jan 16, 2024
8 checks passed
@github-actions github-actions bot mentioned this pull request Jan 16, 2024
Merged
@imartinez imartinez mentioned this pull request Jan 17, 2024
Closed
simonbermudez pushed a commit to simonbermudez/saimon that referenced this pull request Feb 24, 2024
@simonbermudez
feat: add mistral + chatml prompts (zylon-ai#1426)
8a2da9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jaris louis-jaris louis-jaris left review comments

@imartinez imartinez imartinez approved these changes

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cognitivetech @imartinez @louis-jaris