-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use src map if dst is nil and can't be set #177
Conversation
Hello, @ndeloof! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
SourceLevel has finished reviewing this Pull Request and has found:
|
see darccio#90 Signed-off-by: Nicolas De Loof <[email protected]>
Hello @imdario! Thanks! |
@ulyssessouza Done. Thanks @ndeloof! |
As a struct field of type
map
is processed, and was not initialized as non-nil, don't try to set with a fresh new map and just adopt src value.As I'm not sure about the potential side-effects, I've kept the original logic for cases where dst can be set.
fix #90
related: