fixed issue with not overriding of existing value of map

[nl5887]

fixed issue with not overriding of existing value of map, and added expect

[darccio]

By "overriding existing value" I assume you mean same key in both maps but different values. I need to check this pull before accepting it, although it looks fine.

But Mergo doesn't override values in destination by design, so I'm not sure if this pull shouldn't have some more changes to keep current semantics. We may add a parameter or create a new function called "Crush" "Fusion" or "OverridingMerge" (just some quick ideas).

[nl5887]

In my case the use case is that I got a default configuration (dest) and a yaml configuration (src), default values of the configuration will be overridden by configuration.

What about MapWithOverwrite and MergeWithOverwrite? Have to do a lot of testing (and add some extra tests), but this will work. Have a first version now, but old tests are (still) failing, will work on that.

[darccio]

Fine for me. Anyway, I would use Mergo in the opposite way, using your yaml configuration as destination and the default one as source. In this way, you get the same result, unset options will have your default values while keeping your custom values.

[nl5887]

I tested that also, but for me it wasn't updating or adding values if the destination (map in this case) already exists. The patch attached will introduce 2 new functions, MergeWithOverwrite and MapWithOverwrite, which will only overwrite with non empty values.