Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add More Modern TLS Support for Install-Remotely.ps1 #899

Closed
anedward01 opened this issue Jun 16, 2024 · 1 comment
Closed

Add More Modern TLS Support for Install-Remotely.ps1 #899

anedward01 opened this issue Jun 16, 2024 · 1 comment
Assignees

Comments

@anedward01
Copy link

Describe the bug

In the Install-Remotely.ps1 script, there is a hardcode to only support tls1.2 located at line 20:

[System.Net.ServicePointManager]::SecurityProtocol = [System.Net.SecurityProtocolType]::Tls12

My environment only supports tls1.3 connections which was causing the script to error out. To remedy this, I replaced line 20 with the following:

[Net.ServicePointManager]::SecurityProtocol = "tls13, tls12"

This allowed me to successfully download and install the application. It's not the best code, but it works well enough for what it serves.

To Reproduce
Steps to reproduce the behavior:

  1. Set up a proxy that only supports TLS1.3 (Cloudflare custom settings in my case)
  2. Attempt to run the script
  3. Run into a generic error on line 107
  4. Run only the line 107 snippet
  5. Get a TLS/SSL error

Remotely Version
Server (can be found on about page): 2024.02.23.1927
Agent (can be found in device card): 2024.02.23.1927

Expected Behavior
A clear and concise description of what you expected to happen.

When running the install script, the Invoke-WebRequest should successfully process.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser: Firefox
  • Version: 127

Smartphone (please complete the following information):

  • Device: N/A
  • OS: N/A
  • Browser: N/A
  • Version: N/A

Additional Context
Add any other context about the problem here.

  • [ X] I am running Remotely in Docker and not on my QNAP, Synology, or Internet Connected Toaster
@bitbound bitbound self-assigned this Jun 27, 2024
@bitbound
Copy link
Collaborator

Added in the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants