Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Star rating for unowned asset is read-only but appears writable #11829

Closed
1 of 3 tasks
C-Otto opened this issue Aug 15, 2024 · 3 comments · Fixed by #11966
Closed
1 of 3 tasks

Star rating for unowned asset is read-only but appears writable #11829

C-Otto opened this issue Aug 15, 2024 · 3 comments · Fixed by #11966

Comments

@C-Otto
Copy link
Contributor

C-Otto commented Aug 15, 2024

The bug

If I share an album owned by user A with user B, user B is able to see the star rating for those assets. However, user B seems also be able to SET the star rating (the stars change when moving the mouse over them) - but setting the rating does not work.

Either user B should be able to set the rating, or the UI should indicate that this is a read-only property.

The OS that Immich Server is running on

Debian Stable

Version of Immich Server

v1.112.0

Platform with the issue

  • Server
  • Web
  • Mobile

Reproduction steps

  1. Create album with user A
  2. Share album with user B
  3. As user B, set star rating for one of the assets in the album
@C-Otto
Copy link
Contributor Author

C-Otto commented Aug 15, 2024

Similarly, I see the option to identify people (I see the list of detected-but-not-named persons) for assets that are part of the "share all" feature. I don't see this for shared assets in (my own) albums. When I try to edit a person, though, I get a permission error.

@stumpigit
Copy link
Contributor

Thank you. I could reproduce that. The Star Rating component is actually called correct as read-only. So no request is sent when clicking on the stars. But we have not switched off the hover effect in the component when it is read-only. We still need to adjust this, thanks for the tip.

@flammermann
Copy link

A similar issue occurs if you are using an external library from a volume mounted as read only. The star rating seems to be available but there is an error in the immich_server container that the xmp file could not be created/written.

Since we are on the topic:

  1. Is there any plan on allowing star ratings for read only external libraries?
  2. It would probably also be a nice feature to allow people I shared an asset with to provide a star rating, which is then shown to me (as the owner of the asset) in the UI in addition to my own rating. (Or maybe even show all people that have access to an asset all ratings from all other people.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants