Error after crop and save to gallery #11800

lukanowa · 2024-08-15T08:37:25Z

The bug

After cropping a photo and trying to save it to the gallery:

The OS that Immich Server is running on

Unraid

Version of Immich Server

1.112.0-1

Version of Immich Mobile App

1.112.1 b154

Platform with the issue

Server
Web
Mobile

Your docker-compose.yml content

Your .env content

Reproduction steps

1. Crop photo,
2. Save to gallery
3. Error: Null check operator used on a null value

Relevant log output

No response

Additional information

No response

etymotic · 2024-08-16T17:02:16Z

I have the same error when cropping images on Android. App version is 1.112.1 installed from github through Obtanium.

Docker logs for immich_server don't show anything unusual. I believe this must be an Android app problem and not a server problem.

helloworld1987 · 2024-08-19T05:42:50Z

I have the same issue on Docker/Debian.

Benedolt · 2024-08-21T12:11:19Z

I get exactly the same issue. I didn't even crop, just rotate from the mobile app.

Android App v1.112.1 build.154
Server (Docker) v1.112.1

mikerjensen · 2024-08-25T10:36:06Z

Same issue, on a Pixel 7A. I think i've had about 2 successful crops out of about 10 attempts. Most of the crops don't appear anywhere on the phone or on the server, despite the 'Image saved' notification (which appears before the 'Null check operator...' notification.
Android App v1.112.1 build.154
Server (Docker) v1.112.1

Not sure it's related, but often when i launch the Android app, i just get the Immich logo frozen on the screen for a minute or so before loading the thumbnails.

plord12 · 2024-08-26T07:28:28Z

I saw the same error when trying a rotate (no crop).

jakev383 · 2024-08-26T18:24:15Z

Seeing the same issue on a Pixel 8, running Android 14. Immich android app version 1.112.1 build.154, server version 1.112.1 as a docker container.
On the Android app, I only have "Camera" selected as the album to backup, not "Recent" (picks up images I do not wish backed up in Immich).
Server logs do not really show much at this detail level, just the websocket connect and disconnect.

Steps to reproduce:

Open app and select image to bring it to full screen
Select Edit from bottom menu
Select Crop from bottom menu
Click rotate-right icon, then the checkmark at top right of screen
Select "Save to gallery"
App pauses for 10 seconds
App shows "Images saved!" message
2 seconds later app shows "Null check operator used on null value" message
Rotated/edited image is saved to device, but does not show in Immich Photo Browser

Turning the app log level to INFO, I believe this is the relevant log entries to coincide with the app error:

2024-08-26 12:25:01.853038 | SEVERE   | ImmichErrorLogger    | PlatformDispatcher - Catch all | Null check operator used on a null value |
#0      MediaQuery._of (package:flutter/src/widgets/media_query.dart:1169)
#1      MediaQuery.of (package:flutter/src/widgets/media_query.dart:1164)
#2      FToast.showToast (package:fluttertoast/fluttertoast.dart:247)
#3      ImmichToast.show (package:immich_mobile/widgets/common/immich_toast.dart:49)
#4      EditImagePage.build.<anonymous closure> (package:immich_mobile/pages/editing/edit.page.dart:107)
<asynchronous suspension>

2024-08-26 11:19:40.316636 | SEVERE   | ImmichErrorLogger    | PlatformDispatcher - Catch all | Null check operator used on a null value |
#0      MediaQuery._of (package:flutter/src/widgets/media_query.dart:1169)
#1      MediaQuery.of (package:flutter/src/widgets/media_query.dart:1164)
#2      FToast.showToast (package:fluttertoast/fluttertoast.dart:247)
#3      ImmichToast.show (package:immich_mobile/widgets/common/immich_toast.dart:49)
#4      EditImagePage.build.<anonymous closure> (package:immich_mobile/pages/editing/edit.page.dart:107)
<asynchronous suspension>

2024-08-26 11:19:07.126812 | SEVERE   | ImmichErrorLogger    | PlatformDispatcher - Catch all | Null check operator used on a null value |
#0      MediaQuery._of (package:flutter/src/widgets/media_query.dart:1169)
#1      MediaQuery.of (package:flutter/src/widgets/media_query.dart:1164)
#2      FToast.showToast (package:fluttertoast/fluttertoast.dart:247)
#3      ImmichToast.show (package:immich_mobile/widgets/common/immich_toast.dart:49)
#4      EditImagePage.build.<anonymous closure> (package:immich_mobile/pages/editing/edit.page.dart:107)
<asynchronous suspension>

2024-08-26 11:19:00.568383 | SEVERE   | ImmichErrorLogger    | PlatformDispatcher - Catch all | Null check operator used on a null value |
#0      MediaQuery._of (package:flutter/src/widgets/media_query.dart:1169)
#1      MediaQuery.of (package:flutter/src/widgets/media_query.dart:1164)
#2      FToast.showToast (package:fluttertoast/fluttertoast.dart:247)
#3      ImmichToast.show (package:immich_mobile/widgets/common/immich_toast.dart:49)
#4      EditImagePage.build.<anonymous closure> (package:immich_mobile/pages/editing/edit.page.dart:107)
<asynchronous suspension>

2024-08-26 11:18:52.252627 | SEVERE   | ImmichErrorLogger    | PlatformDispatcher - Catch all | Null check operator used on a null value |
#0      MediaQuery._of (package:flutter/src/widgets/media_query.dart:1169)
#1      MediaQuery.of (package:flutter/src/widgets/media_query.dart:1164)
#2      FToast.showToast (package:fluttertoast/fluttertoast.dart:247)
#3      ImmichToast.show (package:immich_mobile/widgets/common/immich_toast.dart:49)
#4      EditImagePage.build.<anonymous closure> (package:immich_mobile/pages/editing/edit.page.dart:107)
<asynchronous suspension>

2024-08-26 11:18:32.618419 | INFO     | AssetNotifier        | Load assets: 1090ms |
2024-08-26 11:18:32.618339 | INFO     | AlbumService         | Syncing completed. Changes: false |
2024-08-26 11:18:31.836496 | INFO     | AlbumService         | 'Recents' is not selected, keeping only selected albums |

jakev383 · 2024-08-31T07:55:02Z

With version 1.113.0 it no longer displays the error message and seems to save the cropped image, although in a different location. Original image was at /storage/emulated/0/DCIM/Camera and crop save location is /storage/emulated/0/Pictures

mikerjensen · 2024-09-02T15:40:52Z

Yes, great progress, i'm now able to save cropped images to the server. Would be great if the cropped image could preserve the date of the original image. And maybe ask if the original (uncropped image) should be deleted?

yashrajjain726 · 2024-10-07T18:16:51Z

Great idea @mikerjensen , I would like to proceed, but just needs the confirmation if we wanted to have the functionality of deleting the orginal photo's once it is cropped and saved into new ones ?

mikerjensen · 2024-10-07T19:10:58Z

Thanks, well mostly i delete the original, but sometimes I crop the original photo twice - to focus on a different part of the image each time, and sometimes one might still want to retain the original after making a crop, so it would be good to have something like a 'delete original?' dialogue after each crop? On 10/7/24 21:17, Yashraj Jain wrote: Great idea @mikerjensen , I would like to proceed, but just needs the confirmation if we wanted to have the functionality of deleting the orginal photo's once it is cropped and saved into new ones ? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***> [ { ***@***.***": "http://schema.org", ***@***.***": "EmailMessage", "potentialAction": { ***@***.***": "ViewAction", "target": "#11800 (comment)", "url": "#11800 (comment)", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { ***@***.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

yashrajjain726 · 2024-10-08T06:46:26Z

Great @mikerjensen , I can start working on this. But I think this card isn't relevant to the issue that we are proceeding on, so can we start with a new issue, where we can start there and close this issue, as this is fixed.

yashrajjain726 · 2024-10-08T09:23:35Z

Hey @mikerjensen , as you mentioned, I have added the new functionality of asking a user to delete the orginal image after the crop functionality.

mikerjensen · 2024-10-12T15:18:18Z

This is really great!, I can't wait to try it! Also wondering if some key image info might be preserved - perhaps you also included that in the upcoming version, as currently it seems that that the cropped image doesn't include the location info? On 10/8/24 12:23, Yashraj Jain wrote: Hey @mikerjensen , as you mentioned, I have added the new functionality of asking a user to delete the orginal image after the crop functionality. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***> [ { ***@***.***": "http://schema.org", ***@***.***": "EmailMessage", "potentialAction": { ***@***.***": "ViewAction", "target": "#11800 (comment)", "url": "#11800 (comment)", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { ***@***.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

plord12 · 2024-10-15T21:37:05Z

With version 1.113.0 it no longer displays the error message and seems to save the cropped image, although in a different location. Original image was at /storage/emulated/0/DCIM/Camera and crop save location is /storage/emulated/0/Pictures

I see the same with 1.118.0. ie, on android -

Edit photo - say apply rotation
Save to gallery
"Image Saved" reported
Image is saved in /storage/Pictures directory and doesn't make it back to immich

danieldietzler added the 📱mobile label Sep 23, 2024

yashrajjain726 linked a pull request Oct 8, 2024 that will close this issue

func: added should delete orginal after crop functionality #13279

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Error after crop and save to gallery #11800

Error after crop and save to gallery #11800

lukanowa commented Aug 15, 2024

etymotic commented Aug 16, 2024 •

edited

Loading

helloworld1987 commented Aug 19, 2024

Benedolt commented Aug 21, 2024

mikerjensen commented Aug 25, 2024

plord12 commented Aug 26, 2024

jakev383 commented Aug 26, 2024

jakev383 commented Aug 31, 2024

mikerjensen commented Sep 2, 2024

yashrajjain726 commented Oct 7, 2024

mikerjensen commented Oct 7, 2024 via email

yashrajjain726 commented Oct 8, 2024 •

edited

Loading

yashrajjain726 commented Oct 8, 2024

mikerjensen commented Oct 12, 2024 via email •

edited

Loading

plord12 commented Oct 15, 2024

Error after crop and save to gallery #11800

Error after crop and save to gallery #11800

Comments

lukanowa commented Aug 15, 2024

The bug

The OS that Immich Server is running on

Version of Immich Server

Version of Immich Mobile App

Platform with the issue

Your docker-compose.yml content

Your .env content

Reproduction steps

Relevant log output

Additional information

etymotic commented Aug 16, 2024 • edited Loading

helloworld1987 commented Aug 19, 2024

Benedolt commented Aug 21, 2024

mikerjensen commented Aug 25, 2024

plord12 commented Aug 26, 2024

jakev383 commented Aug 26, 2024

jakev383 commented Aug 31, 2024

mikerjensen commented Sep 2, 2024

yashrajjain726 commented Oct 7, 2024

mikerjensen commented Oct 7, 2024 via email

yashrajjain726 commented Oct 8, 2024 • edited Loading

yashrajjain726 commented Oct 8, 2024

mikerjensen commented Oct 12, 2024 via email • edited Loading

plord12 commented Oct 15, 2024

etymotic commented Aug 16, 2024 •

edited

Loading

yashrajjain726 commented Oct 8, 2024 •

edited

Loading

mikerjensen commented Oct 12, 2024 via email •

edited

Loading