Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Support for redis sentinel #473

Closed
onedr0p opened this issue Aug 16, 2022 · 6 comments · Fixed by #2141
Closed

[Feature]: Support for redis sentinel #473

onedr0p opened this issue Aug 16, 2022 · 6 comments · Fixed by #2141

Comments

@onedr0p
Copy link
Contributor

onedr0p commented Aug 16, 2022

Feature detail

Hi 👋🏼

It would be great if immich could connect to a highly available redis instance.

Here's a couple examples of applications that support this method of redis.

Thanks!

Platform

Server

@alextran1502
Copy link
Contributor

Hello,

Thank you for opening the issue. This will be left to the user to implement because it is very specific to a user group

@alextran1502 alextran1502 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 16, 2022
@onedr0p
Copy link
Contributor Author

onedr0p commented Nov 13, 2022

@alextran1502

To be able to implement sentinel support, there would have to be a switch from node-redis to ioredis, since node-redis doesn't have sentinel support redis/node-redis#302 :/

Would you accept PRs on this change?

@alextran1502
Copy link
Contributor

You can try but I think there might be dependencies that depends on node-redis, like the socket-io implementation

@onedr0p
Copy link
Contributor Author

onedr0p commented Nov 13, 2022

Actually it looks like Bull passes the RedisOpts directly to ioredis, not sure why the redis lib is in the packages.json

https://github.com/OptimalBits/bull/blob/master/REFERENCE.md#queue

Since with Redis Sentinel would require multiple hosts passthru to the application, do you think the way Outline made it configurable is a decent decision for implentation?

https://github.com/luin/ioredis#sentinel

@alextran1502
Copy link
Contributor

Here is the reason we have Redis in the dependency https://docs.nestjs.com/websockets/adapter

@samip5
Copy link
Contributor

samip5 commented Mar 31, 2023

@alextran1502 Could you re-open this so it would get closed when the support is implemented from the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants