Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memo parser: LRU capped cache #1075

Closed
benmosher opened this issue Apr 11, 2018 · 3 comments
Closed

memo parser: LRU capped cache #1075

benmosher opened this issue Apr 11, 2018 · 3 comments

Comments

@benmosher
Copy link
Member

turns out the memo parser really soaks up memory on large projects in v2.

setting: max number of modules to cache (50 or so by default?) to keep it lighter?

need to test cache hit frequency then, though.

first: measure perf improvement of memo-parser using v2, vs. not using it. maybe should just ditch it if it's not substantial anymore

@benmosher
Copy link
Member Author

discovered while investigating #1058 (this explains why I see the same memory/perf in 2.9)

@benmosher
Copy link
Member Author

another idea: use FS for cache instead of memory? needs perf observation also.

spec: some tmp folder with content-hash-based filenames holding AST JSON? actually maybe that's not achievable since the AST is not a DAG

@benmosher
Copy link
Member Author

yeah, nvm, it doesn't seem to matter anymore so closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant