Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semver version #2805

Closed
Badisi opened this issue Jun 26, 2023 · 3 comments
Closed

Update semver version #2805

Badisi opened this issue Jun 26, 2023 · 3 comments

Comments

@Badisi
Copy link

Badisi commented Jun 26, 2023

Npm's report recommend to update semver dependency version.

Versions of the package semver before 7.5.2 are vulnerable to Regular Expression Denial of Service (ReDoS) via the function new Range, when untrusted user data is provided as a range.

Source: github.com/advisories/GHSA-c2qf-rxjj-qqgw

@ljharb
Copy link
Member

ljharb commented Jun 26, 2023

Like most CVEs, it's a false positive. We're not using new Range nor are we doing anything that wouldn't be a self-attack (ie, not an attack).

We can't ever bump the semver version because v7 drops support for engines we support, so unless the fix is backported to v6, it'll just have to remain a false positive.

Duplicate of #2803. Duplicate of #2804.

@ljharb ljharb closed this as not planned Won't fix, can't repro, duplicate, stale Jun 26, 2023
@Badisi
Copy link
Author

Badisi commented Jun 26, 2023

Sorry for the duplicates.

If by engine you mean node >= 4, don't you think it's time to drop it too ?
Or at least maintain a legacy and latest version of your library ?

@ljharb
Copy link
Member

ljharb commented Jun 26, 2023

Nope, it'll likely never be time to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants