You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I left a comment on #479 already, but basically; why do you need this? I don't think it's as clear cut as just doing it opportunistically. Is there any option for you to implement Flush on your ResponseWriter instead?
There are 2 reason why I think this should be solved in the wrapper.
The api semantics don't specify anything regarding the ResponseWriter having to implement http.Flusherand should in that case treat as an optional feature or change the api to take a Flusher instance.
Implementing a "dummy" Flush func also means flush might be called assuming the normal semantics and in fact nothing will happen
Versions of relevant software used
v0.9.6
What happened
Panic when cast to interface
What you expected to happen
Method should only be called upon successful cast
How to reproduce it (as minimally and precisely as possible):
Call webGrpcResponse.Flush() with
wrapped
being an instance of http.ResponseWriterThe text was updated successfully, but these errors were encountered: