Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cowboy and ranch version not compatible ? #130

Closed
zmstone opened this issue May 25, 2021 · 5 comments · Fixed by #131
Closed

cowboy and ranch version not compatible ? #130

zmstone opened this issue May 25, 2021 · 5 comments · Fixed by #131

Comments

@zmstone
Copy link
Contributor

zmstone commented May 25, 2021

What's the reason to use ranch 2.0.0 while cowboy 2.8.0 actually depend on ranch 1.7.1 ?
I believe the example app is having various issues due to this

@elbrujohalcon
Copy link
Member

That's most likely true, but since we're not actively maintaining this project that much anymore… it might take a while until it's fixed.

That is… unless you feel like submitting a PR 😉

@paulo-ferraz-oliveira
Copy link
Collaborator

I bumped ranch in #126, pretty sure due to static analysis issues. Tests didn't complain. Running this in production didn't either, so I assumed everything was Okay. It is possible the example app is either not being tested or not updated properly (I don't remember having looked at it). Pull requests are accepted, though 😉

@zmstone
Copy link
Contributor Author

zmstone commented May 26, 2021

That's most likely true, but since we're not actively maintaining this project that much anymore… it might take a while until it's fixed.

That is… unless you feel like submitting a PR 😉

We are trying to adopt cowboy_swagger in our project. May I ask why you have stopped (actively) maintaining it?

@zmstone
Copy link
Contributor Author

zmstone commented May 26, 2021

I bumped ranch in #126, pretty sure due to static analysis issues. Tests didn't complain. Running this in production didn't either, so I assumed everything was Okay. It is possible the example app is either not being tested or not updated properly (I don't remember having looked at it). Pull requests are accepted, though 😉

I will try to test it again and get back to you with the incompatible parts.

@zmstone
Copy link
Contributor Author

zmstone commented May 26, 2021

for example: {connection_type, supervisor} leaked down to inet as socket options, resulting in this crash:

=CRASH REPORT==== 26-May-2021::16:36:33.466341 ===
  crasher:
    initial call: supervisor:ranch_acceptors_sup/1
    pid: <0.471.0>
    registered_name: []
    exception exit: badarg
      in function  inet_tcp:listen/2 (inet_tcp.erl, line 142)
      in call from ranch_acceptors_sup:start_listen_socket/4 (ranch_acceptors_sup.erl, line 78)
      in call from ranch_acceptors_sup:start_listen_sockets/5 (ranch_acceptors_sup.erl, line 54)
      in call from ranch_acceptors_sup:init/1 (ranch_acceptors_sup.erl, line 34)
      in call from supervisor:init/1 (supervisor.erl, line 301)
      in call from gen_server:init_it/2 (gen_server.erl, line 417)
      in call from gen_server:init_it/6 (gen_server.erl, line 385)
    ancestors: [<0.459.0>,ranch_sup,<0.442.0>]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants