Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support component parameters #140

Merged
merged 1 commit into from
Sep 22, 2021
Merged

support component parameters #140

merged 1 commit into from
Sep 22, 2021

Conversation

zhongwencool
Copy link
Contributor

support component parameters.

"components": {
  "schemas": {...}
  "parameters":  
      "per-page": {
         "name": "per_page",
         "description": "Results per page (max 100)",
         "in": "query",
         "schema": {
            "type": "integer",
            "default": 30
         }
       },
      "cursor": {
        "name": "cursor",
        "description": "Used for pagination....",
        "in": "query",
        "required": false,
        "schema": {
           "type": "string"
        }
      }
}

use as ref:

"parameters": [
          {
            "$ref": "#/components/parameters/per-page"
          },
          {
            "$ref": "#/components/parameters/cursor"
          }
        ]

@zhongwencool
Copy link
Contributor Author

ping @elbrujohalcon :0

@elbrujohalcon
Copy link
Member

Hummm… it looks like you introduced an unused export… 🤔

@zhongwencool
Copy link
Contributor Author

Hummm… it looks like you introduced an unused export… 🤔

cowboy_swagger:get_existing_definitions/1 only use by ct test, I change it to cowboy_swagger:get_existing_definitions/2.

I let xref to ignore this.

@elbrujohalcon
Copy link
Member

👌🏻

@elbrujohalcon
Copy link
Member

Well… now elvis is complaining 🤷🏻

@zhongwencool
Copy link
Contributor Author

Well… now elvis is complaining 🤷🏻

done....

@elbrujohalcon
Copy link
Member

😢 We still have trailing whitespaces 🤷🏻

@elbrujohalcon elbrujohalcon merged commit 0202c98 into inaka:master Sep 22, 2021
@zhongwencool zhongwencool deleted the component-parameters branch September 22, 2021 13:38
@zhongwencool
Copy link
Contributor Author

@elbrujohalcon WOW, Thank you very much for this very useful library. 👍
Could you give me a new tag?

@elbrujohalcon
Copy link
Member

You got it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants