make serving path configurable #204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,7 +8,7 @@ | |||
| %% Handlers | |||
| -export([resource_exists/2, previously_existed/2, moved_permanently/2]). | |||
|
|
|||
| -type state() :: #{}. | |||
| -type state() :: {file, string()}. | |||
There was a problem hiding this comment.
Why not #{file := string()}?
There was a problem hiding this comment.
I Just used what was already passed. So this is a fix for type spec. Dialyzer is happy now.
| url: window.location.origin + "/api-docs/swagger.json", | ||
| url: window.location.toString().replace("/index.html", "/swagger.json"), |
There was a problem hiding this comment.
Could you explain this change, please?
Also, I can't remember, but are we testing this somewhat?
You might want to look into up_swagger.sh because there's logic for this file, there.
Comment on lines
-39
to
+40
| {file, StaticFiles ++ "/index.html"}, | ||
| {file, Path ++ "/index.html"}, |
There was a problem hiding this comment.
I seem to not be able to follow this change. Would you elaborate, please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes there is a need to use a custom path for Swagger UI. It is hard-coded as api-docs at the moment. Here is proposed implementation.