Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fave status lost when leaving ObsDetails #1880

Open
kueda opened this issue Jul 29, 2024 · 0 comments · May be fixed by #2091
Open

Fave status lost when leaving ObsDetails #1880

kueda opened this issue Jul 29, 2024 · 0 comments · May be fixed by #2091
Assignees
@budowski
Labels
bug Something isn't working user bug Bugs reported by users
Milestone
Hard Launch (iOS)

Comments

@kueda
Copy link
Member

kueda commented Jul 29, 2024 •
edited
Loading

Describe the bug
When you fave an obs, the vote gets submitted but the star isn't filled in when you go back to ObsDetails

To Reproduce
Steps to reproduce the behavior:

  1. Sign in
  2. Go to ObsDetails for one of your existing observations
  3. Tap the star button to fave it. It should change from an outline to a fill
  4. Tap back to return to MyObs
  5. Tap on the same obs again to enter ObsDetails
  6. The star button is in outline mode again

Expected behavior
When you return to ObsDetails, the star button should remain filled b/c you faved it.

Context (please complete the following information):

  • Device: iPhone SE (3rd gen)
  • OS: 17.5.1
  • App version: 0.37.0 (103)

Additional context
FWIW, the fave does seem to get submitted to the website. Not sure why we're not pulling in the web state of the obs when you return to ObsDetail.

If you force quit the app and restart, then go back to ObsDetail, the fave button is filled in.
@kueda kueda added bug Something isn't working user bug Bugs reported by users labels Jul 29, 2024
@kueda kueda added this to the Hard Launch milestone Jul 30, 2024
@budowski budowski self-assigned this Sep 3, 2024
budowski added a commit that referenced this issue Sep 16, 2024
@budowski
Fix #1880 - Observation details - properly show fave status for obser…
fbd2e72 
…vation
@kueda kueda linked a pull request Sep 17, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@budowski budowski

Labels
bug Something isn't working user bug Bugs reported by users
Projects
iNat Mobile
Status: Todo
Milestone
Hard Launch (iOS)
Development

Successfully merging a pull request may close this issue.

fix: fave status was lost when leaving ObsDetails inaturalist/iNaturalistReactNative
2 participants
@kueda @budowski