Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

write_dwc() and write_eml() should not write to "." by default #70

Closed
4 tasks done
peterdesmet opened this issue Jun 4, 2024 · 0 comments · Fixed by #75
Closed
4 tasks done

write_dwc() and write_eml() should not write to "." by default #70

peterdesmet opened this issue Jun 4, 2024 · 0 comments · Fixed by #75
Assignees
@sannegovaert
Milestone
0.4.0

Comments

@peterdesmet
Copy link
Member

peterdesmet commented Jun 4, 2024 •
edited by sannegovaert
Loading

This is a violation of CRAN policies, see inbo/camtrapdp#79

  • Provide no default for directory
  • Verify tests still run
  • Verify vignette needs update
  • Update example (use "my_directory" and clean up, see camtrapdp::write_dwc()`)
@peterdesmet peterdesmet changed the title write_dwc() should not write to "." by default write_dwc() and write_dwc() should not write to "." by default Jun 5, 2024
@sannegovaert sannegovaert changed the title write_dwc() and write_dwc() should not write to "." by default write_dwc() and write_eml() should not write to "." by default Jun 6, 2024
@sannegovaert sannegovaert mentioned this issue Jun 7, 2024
Merged
@peterdesmet peterdesmet added this to the 0.4.0 milestone Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sannegovaert sannegovaert

Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

Successfully merging a pull request may close this issue.

write_dwc updates inbo/movepub
2 participants
@peterdesmet @sannegovaert