Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify ninja on FreeBSD, SunOS, possibly other unixes? #1

Open
1 of 3 tasks
indutny opened this issue Jun 12, 2016 · 3 comments
Open
1 of 3 tasks

Verify ninja on FreeBSD, SunOS, possibly other unixes? #1

indutny opened this issue Jun 12, 2016 · 3 comments

Comments

@indutny
Copy link
Owner

indutny commented Jun 12, 2016

ninja, the only, output of gyp.js needs to be verified on:

  • FreeBSD
  • SunOS
  • Others?...

Suggested way to verify:

  1. install node.js on that platform
  2. git clone https://github.com/ninja-build/ninja.git && cd ninja && ./configure.py --boostrap && export PATH="cwd:$PATH"
  3. git clone https://github.com/indutny/gyp.js && cd gyp.js && npm i && cd ..
  4. git clone https://github.com/nodejs/node && cd node
  5. ./configure
  6. ../gyp.js/bin/gyp -Icommon.gypi -Iconfig.gypi node.gyp -Dtarget_arch=x64 -Dhost_arch=x64
  7. ninja -C out/Release
  8. Build should succeed, and ./out/Release/node should start
  9. Bonus step: python tools/test.py --mode=release -J parallel sequential
@jbergstroem
Copy link
Contributor

jbergstroem commented Jun 12, 2016

Few warnings, ninja otherwise build fine on SmartOS. Will test the full chain next.

#  uname -a
SunOS 9678352e-dcfd-ee03-eba3-e4b1c4c04512 5.11 joyent_20160527T033640Z i86pc i386 i86pc Solaris

# ./configure.py --bootstrap
bootstrapping ninja...
warning: A compatible version of re2c (>= 0.11.3) was not found; changes to src/*.in.cc will not affect your build.
./src/ninja.cc: In function 'int {anonymous}::ReadFlags(int*, char***, {anonymous}::Options*, BuildConfig*)':
./src/ninja.cc:996:3: warning: deprecated conversion from string constant to 'char*' [-Wwrite-strings]
   };
   ^
./src/ninja.cc:996:3: warning: deprecated conversion from string constant to 'char*' [-Wwrite-strings]
wrote build.ninja.
bootstrap complete.  rebuilding...
[19/23] CXX build/ninja.o
src/ninja.cc: In function 'int {anonymous}::ReadFlags(int*, char***, {anonymous}::Options*, BuildConfig*)':
src/ninja.cc:996:3: warning: deprecated conversion from string constant to 'char*' [-Wwrite-strings]
   };
   ^
src/ninja.cc:996:3: warning: deprecated conversion from string constant to 'char*' [-Wwrite-strings]

@jbergstroem
Copy link
Contributor

Fails; looks simple to fix:

ninja: error: '../../src/node_dtrace_ustack.cc', needed by 'obj/src/node.node_dtrace_ustack.o', missing and no known rule to make it

@indutny
Copy link
Owner Author

indutny commented Jun 12, 2016

@jbergstroem It looks like I get pretty much the same error with original GYP on OS X, if I uncomment ustack sections...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants