Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZstdDecompressor stream_reader doesn't support readline() #39

Closed
gcp opened this issue Feb 9, 2018 · 2 comments
Closed

ZstdDecompressor stream_reader doesn't support readline() #39

gcp opened this issue Feb 9, 2018 · 2 comments

Comments

@gcp
Copy link

gcp commented Feb 9, 2018

The documentation for ZstdCompressor explicitly says that stream_reader's file-like object doesn't support readline() because it makes no sense for compressed data. For Decompressor, this remark is missing - as it should be - but the function doesn't seem to be implemented and throws NotImplementedError.

@gcp
Copy link
Author

gcp commented Feb 9, 2018

PyErr_SetNone(PyExc_NotImplementedError);

@indygreg
Copy link
Owner

I'm going to call this a duplicate of #13.

I have a patch for readline() that's been sitting around. I need to polish it up and land it. I'm not a fan of adding a buffering layer in order to provide readline(). But enough consumers want a file-like object and readline() is part of that interface. So it should be implemented. I'll try to deliver this in the 0.9 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants