This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
Update to community managed AsyncStorage #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ryanlntn
commented
May 10, 2019
ryanlntn
commented
- Updates to use community managed AsyncStorage (resolves Update to community managed AsyncStorage #190)
- Will still have a yellowbox warning until Update to use new community AsyncStorage reactotron-react-native#14 is resolved
yulolimum
reviewed
May 10, 2019
| @@ -0,0 +1,3 @@ | |||
| import mockAsyncStorage from "@react-native-community/async-storage/jest/async-storage-mock" | |||
|
|
|||
| jest.mock("@react-native-community/async-storage", () => mockAsyncStorage) | |||
There was a problem hiding this comment.
yes! i've been waiting for this! thx
yulolimum
approved these changes
May 10, 2019
kevinvangelder
suggested changes
May 10, 2019
@kevinvangelder It is https://github.com/infinitered/ignite-bowser/pull/192/files#diff-a1ce4c85f71433483b1ca574f5213704R29 |
infinitered-circleci
pushed a commit
that referenced
this pull request
May 10, 2019
## [4.4.1](v4.4.0...v4.4.1) (2019-05-10) ### Bug Fixes * **deps:** Update to community managed AsyncStorage (resolves [#190](#190)) ([#192](#192) by [@ryanlntn](https://github.com/ryanlntn)) ([52e1e43](52e1e43))
|
🎉 This PR is included in version 4.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.