This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting to work on finishing #275, I noticed that
yarn lint
for the Bowser project itself (that is, not the generated app) was really linting the compiled javascript instead of the original typescript.Fixing that got me a complaint that the typescript-eslint parser & plugin weren't compatible with my version of Typescript (which always seems to be "latest" because we don't commit our yarn.lock, and because of yarn hoisting... I think).
So I upgraded them, and fixed a few new complaints they produced. I also upgraded them in the generated apps, and fixed new (but different!) complaints there.
Running the tests (in the outer project) will now also lint (with
--fix
), just to help keep things linty-fresh. (CI will also lint, but without--fix
.)