Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shouldn't we evict the connection pool on close? #286

Closed
denismarin opened this issue Feb 16, 2017 · 2 comments
Closed

Shouldn't we evict the connection pool on close? #286

denismarin opened this issue Feb 16, 2017 · 2 comments
Labels
kind/bug

Comments

@denismarin
Copy link

Is there any reason you are leaving the OkHttpClient untouched on close?

I would think to evict the connection pool here. Leaving a leak in my container as it is.
@majst01
Copy link
Collaborator

majst01 commented Feb 24, 2017

Please open a PR therefore, i think this is a good idea.

@kboshold kboshold mentioned this issue Aug 2, 2017
Closed
@asashour asashour mentioned this issue Feb 1, 2019
Merged
@asashour
Copy link
Contributor

asashour commented Feb 1, 2019

I guess this should be closed.

@majst01 majst01 closed this as completed Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@majst01 @fmachado @asashour @denismarin