Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize IDs as integers and not strings in PersistedSnapshot #25491

Closed
hiltontj opened this issue Oct 25, 2024 · 1 comment · Fixed by #25541
Closed

Serialize IDs as integers and not strings in PersistedSnapshot #25491

hiltontj opened this issue Oct 25, 2024 · 1 comment · Fixed by #25541
Assignees
Labels

Comments

@hiltontj
Copy link
Contributor

The PersistedSnapshot type is serializing the DbId and TableId keys in the databases/tables map as strings. It should instead serialize as a an array of structs, then deserializing as the map with integer keys.

@hiltontj hiltontj added the v3 label Oct 25, 2024
@hiltontj hiltontj self-assigned this Oct 25, 2024
@hiltontj
Copy link
Contributor Author

hiltontj commented Nov 4, 2024

See:

pub struct SerdeVecMap<K: Eq + std::hash::Hash, V>(IndexMap<K, V>);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant