Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing HMAC validation of events in GithubWebhook #1661

Closed
ecneladis opened this issue Aug 23, 2016 · 1 comment
Closed

Missing HMAC validation of events in GithubWebhook #1661

ecneladis opened this issue Aug 23, 2016 · 1 comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin

Comments

@ecneladis
Copy link

Bug report

GithubWehook does not validate event's value of X-Hub-Signature that provide authentication of incoming messages.

It's a security issue, currently this webhook access any incoming events.

Expected behaviour:

Get secret (that's shared with github) from the config file and use it to verify authenticity of incoming events. Github documentation.
@francois2metz
Copy link
Contributor

I agree. In the meantime you can have some security via obscurity by exposing a path like /github_SefWup5ob.

@jwilder jwilder added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Sep 1, 2016
@francois2metz francois2metz mentioned this issue Mar 5, 2017
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@francois2metz @jwilder @ecneladis