Unlock Statsd when stopping to prevent deadlock #3258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnivade
reviewed
Sep 22, 2017
| } | ||
|
|
||
| time.Sleep(time.Millisecond * 25) | ||
| conn, err := net.Dial("udp", "127.0.0.1:8125") |
There was a problem hiding this comment.
Should we write another benchmark which tests concurrent writing to multiple connections spawned in goroutines ? I think that might be closer to real world scenarios.
There was a problem hiding this comment.
I'm not sure it will change much in the case of UDP to have multiple senders. I do wish we had a test that we could run forever, similar to https://github.com/influxdata/influx-stress. Maybe something as already been written for statsd?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed we have a TCP Benchmark but not one for UDP, which would be useful for #3254 so I added one based on the existing test. When running this I found that the plugin can deadlock on shutdown if there are messages pending on the input channel.
cc @agnivade
Required for all PRs:
Associated README.md updated.NA