Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nagios parser does not strip quotes from performance data #4088

Closed
danielnelson opened this issue Apr 30, 2018 · 2 comments
Closed

Nagios parser does not strip quotes from performance data #4088

danielnelson opened this issue Apr 30, 2018 · 2 comments
Labels
breaking change Improvement to Telegraf that requires changes to the plugin or agent; for minor/major releases bug unexpected problem or unintended behavior
Milestone

Comments

@danielnelson
Copy link
Contributor

Bug report

The nagios parser should remove quoting from the performance data.

See https://nagios-plugins.org/doc/guidelines.html#AEN200 for details.

Relevant telegraf.conf:

[[inputs.exec]]
  commands = ["cat nagios"]
  data_format = "nagios"
$ cat nagios
OK: Load average: 0.00, 0.01, 0.05 | 'load1'=0.00;0:4;0:6;0; 'load5'=0.01;0:3;0:5;0; 'load15'=0.05;0:2;0:4;0;

System info:

Telegraf 1.6.1

Steps to reproduce:

  1. telegraf --input-filter exec --test

Expected behavior:

> nagios_state state=0i 1525116499000000000
> load1 min=0,value=0 1525116499000000000
> load5 min=0,value=0.01 1525116499000000000
> load15 min=0,value=0.05 1525116499000000000

It might be better to turn the label into a tag:

> nagios state=0i 1525116499000000000
> nagios,perfdata=load1 min=0,value=0 1525116499000000000
> nagios,perfdata=load5 min=0,value=0.01 1525116499000000000
> nagios,perfdata=load15 min=0,value=0.05 1525116499000000000

Actual behavior:

> nagios_state state=0i 1525116499000000000
> 'load1' min=0,value=0 1525116499000000000
> 'load5' min=0,value=0.01 1525116499000000000
> 'load15' min=0,value=0.05 1525116499000000000
@danielnelson danielnelson added breaking change Improvement to Telegraf that requires changes to the plugin or agent; for minor/major releases bug unexpected problem or unintended behavior labels Apr 30, 2018
@pierrick-openIT
Copy link

Hello, have you any news for this issues ?

@danielnelson
Copy link
Contributor Author

No sorry, I haven't had time to work on it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Improvement to Telegraf that requires changes to the plugin or agent; for minor/major releases bug unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants