Elasticsearch 6 lost some attribute/tags in _nodes api

[bbfoto]

We just noticed in our automated es dashboards, that our shiny new es6 cluster doesn't distinguish between data and master nodes.

traced it down to I suspect a breaking change on es side that affects the way es telegraf plugin is tagging metrics...

in line 30, Attributes map[string]string json:"attributes"`` seems to not work anymore.
I feel this kind of has a vague reference to it.
https://www.elastic.co/guide/en/elasticsearch/reference/5.5/breaking_50_settings_changes.html#_node_attribute_settings

Looking at es 1.x results vs 6.x results, I think the solution might be to instead of using
Attributes map[string]string json:"attributes"
to attributes or roles depending on es version...
in the es6 _nodes result I have the following for a master

    "roles" : [
        "master",
        "ingest"
      ],

and the following for a datanodes

   "roles" : [
       "data",
       "ingest"
     ],

there is no attributes{} section in my es6 _nodes result.

maybe also of interest. I find in both es1.x and es6.x clusters I do have the following subset of settings.cluster

        "node" : {
          "data" : "true",
          "name" : "<human_readable_hostname>",
          "master" : "false"
         },

I think either node or roles would work for the original intent of attributes.

[danielnelson]

related: #3630

[dupondje]

Which attribute/tags are lost?

I compares ES 5 and ES 6, but they seem both similar.

For the master vs data nodes:
dupondje@ae16792

I'll get this merged asap.

[glinton]

@bbfoto have you tried again with a nightly build since #6064 was merged?

[bbfoto]

will give it a try.

[sjwang90]

@bbfoto has this problem been fixed? please closed if so or provide what error you are still receiving.

[telegraf-tiger]

Hello! I am closing this issue due to inactivity. I hope you were able to resolve your problem, if not please try posting this question in our Community Slack or Community Page. Thank you!