Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csv: TrimLeadingSpace when TrimSpace is on #6773

Merged
merged 1 commit into from
Dec 11, 2019
Merged

csv: TrimLeadingSpace when TrimSpace is on #6773

merged 1 commit into from
Dec 11, 2019

Conversation

DSpeichert
Copy link
Contributor

@DSpeichert DSpeichert commented Dec 9, 2019 •
edited
Loading

When TrimSpace is used and Delimeter is a space, it trips up the CSV reader otherwise.

Visual representation of now-supported format:

   first   second   third   fourth
abcdefgh        0       2    false
  abcdef      3.3       4     true
       f        0       2    false

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson
Copy link
Contributor

Thanks, this seems right, can you add a unit test with an example too?

@danielnelson danielnelson added the fix pr to fix corresponding bug label Dec 9, 2019
@DSpeichert
csv: TrimLeadingSpace when TrimSpace is on
c3daf93 
When TrimSpace is used and Delimeter is a space, the input is not correctly
recognized (empty columns or data mismatch occurrs).
@DSpeichert DSpeichert marked this pull request as ready for review December 10, 2019 05:26
@DSpeichert
Copy link
Contributor Author

@danielnelson done!

@danielnelson danielnelson added this to the 1.13.0 milestone Dec 11, 2019
@danielnelson danielnelson merged commit 98585a1 into influxdata:master Dec 11, 2019
danielnelson pushed a commit that referenced this pull request Dec 11, 2019
@DSpeichert @danielnelson
Set TrimLeadingSpace when TrimSpace is on in csv parser (#6773)
7cf5ea7 
(cherry picked from commit 98585a1)
@DSpeichert DSpeichert deleted the patch-1 branch December 12, 2019 03:16
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
@DSpeichert
Set TrimLeadingSpace when TrimSpace is on in csv parser (influxdata#6773
f1860fa 
)
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
@DSpeichert
Set TrimLeadingSpace when TrimSpace is on in csv parser (influxdata#6773
ecf9bdb 
)
@Hipska Hipska added the area/csv csv parser/serialiser related label Feb 15, 2022
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@DSpeichert @danielnelson
Set TrimLeadingSpace when TrimSpace is on in csv parser (influxdata#6773
d762186 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/csv csv parser/serialiser related fix pr to fix corresponding bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DSpeichert @danielnelson @Hipska