Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Timezone Configuration to CSV Data Format Parser #7618

Closed
haidlir opened this issue Jun 2, 2020 · 1 comment · Fixed by #7619
Closed

Add Timezone Configuration to CSV Data Format Parser #7618

haidlir opened this issue Jun 2, 2020 · 1 comment · Fixed by #7619
Labels
feature request Requests for new plugin and for new features to existing plugins
Milestone

Comments

@haidlir
Copy link
Contributor

haidlir commented Jun 2, 2020

Feature Request

Proposal:

Add a timezone configuration parameter to the CSV data format.

Current behavior:

Currently, any timestamp without timezone within the csv value will treated as UTC.

metricTime, err := internal.ParseTimestamp(timestampFormat, recordFields[timestampColumn], "UTC")

Desired behavior:

There is a way to set the timezone. Otherwise, it will be treated as UTC.

Use case:

There is a possibility that the csv file that we want to parse, containing timestamp column without any timezone information attached to it.

The expected format should be

  • "2006-01-02T15:04:05Z07:00" or
  • "Mon, 02 Jan 2006 15:04:05 MST".

Instead, we get

  • "2020-06-02 21:05:00" in non-UTC timezone

In this case there is no possibility to ask the source to add the timezone information.

@haidlir
Copy link
Contributor Author

haidlir commented Jun 2, 2020

PR #7619

@danielnelson danielnelson added this to the 1.15.0 milestone Jun 8, 2020
@danielnelson danielnelson added the feature request Requests for new plugin and for new features to existing plugins label Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants