Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize the dependencies to use a single TLS stack #1641

Closed
2 of 5 tasks
mzabaluev opened this issue Dec 3, 2021 · 1 comment · Fixed by informalsystems/tendermint-rs#1068 or #1762
Closed
2 of 5 tasks
Labels
I: dependencies Internal: related to dependencies O: new-feature Objective: cause to add a new feature or support

Comments

@mzabaluev
Copy link
Contributor

mzabaluev commented Dec 3, 2021

Summary

Both native-tls/openssl and rustls are present in the dependency tree.

Problem Definition

As of 2e8d839, there are the following dependency chains:

ibcibc-prototonictokio-rustlsrustls
ibctendermint-light-clienttendermint-rpchyper-proxyhyper-tlsnative-tlsopenssl

Use of two TLS stacks bloats up the binary size and increases build time.
The need to link the foreign OpenSSL library complicates the build (see #1569).

Proposal

Choose one of the stacks and make sure all crates in the dependency tree use it.

Looking at the state of the dependency tree, tendermint-rpc is an outlier, pulling in OpenSSL perhaps by oversight: hyper-proxy can be switched to rustls, furthermore, tendermint-rpc itself also depends on hyper-rustls.

Acceptance Criteria

native-tls, openssl are not present in the dependency tree.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@mzabaluev mzabaluev added O: new-feature Objective: cause to add a new feature or support I: dependencies Internal: related to dependencies A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews labels Dec 3, 2021
@mzabaluev mzabaluev removed the A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews label Jan 10, 2022
@mzabaluev
Copy link
Contributor Author

Waiting for the next release of tendermint-rs to solve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: dependencies Internal: related to dependencies O: new-feature Objective: cause to add a new feature or support
Projects
None yet
1 participant