Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop Gaia fork with ICS29 Fee Middleware enabled #1967

Closed
5 tasks
Tracked by #1168
soareschen opened this issue Mar 16, 2022 · 3 comments · Fixed by #1996
Closed
5 tasks
Tracked by #1168

Develop Gaia fork with ICS29 Fee Middleware enabled #1967

soareschen opened this issue Mar 16, 2022 · 3 comments · Fixed by #1996
Labels
O: ics29-fee Objective: Fee middleware support
Milestone

Comments

@soareschen
Copy link
Contributor

Summary

Try to create our own Gaia fork that uses cosmos/ibc-go#276 and release it on Cosmos.nix. This would only be worthwhile if there is not too much work needed to modify the existing Gaia source code. The work may be much smoother if there is already a Gaia branch that targets ibc-go master or ibc-go v3, which unfortunately doesn't appear to be present.

With this Gaia fork, we will be able to perform integration test on the fee middleware before it gets released. Otherwise we can only delay the testing and development until a proper version of Gaia is available.

Meanwhile, we can still start some development in the blind without testing support, at the risk of significant changes might be required depending on the official release.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere
Copy link
Member

adizere commented Mar 22, 2022

Closing this depends on cosmos/ibc-go#1162.

It seems that we are headed towards a two-phase process:

  1. As suggested in Provide an experimental Gaia branch for ICS29 Fee Middleware cosmos/ibc-go#1162, during early phases of development of an IBC-go feature, we would get easy access to that feature by employing simapp. The IBC-go team believe this is the most appropriate way for them to give access to feature for relayer teams.

  2. As the feature matures, it is expected to eventually land in a Gaiad RC. Example: Gaia-v7-rc0 one is a ICA-enabled Gaia RC. This RC is obviously coming out too late for the relayer team to test and develop with, so we have used instead https://github.com/cosmos/interchain-accounts-demo.

For our team, this essentially means we want to develop more support for running tests on simapp, instead of gaiad. (Additionally, I can imagine relying increasingly more on the Gaia team to test their own releases against Hermes, while our team ensures cutting edge features testing with simapp).

@romac
Copy link
Member

romac commented Mar 22, 2022

Just to clarify on point 2, the issue with Gaia 7 is not that the RC came too late for us to test with it but rather that it does not come with the controller module enabled, cf. an internal message from the Go team:

Gaia v7.0.0-rc0 has only the host submodule for interchain accounts enabled. So to use it with the demo on the readme wouldn’t be possible, as you need a controller chain to register an account and send txs.

@soareschen
Copy link
Contributor Author

I have tried the suggestion in cosmos/ibc-go#1162 and tested the integration test CI with the simapp in #1996 and they do seem to work. So this issue can be closed once #1996 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: ics29-fee Objective: Fee middleware support
Projects
No open projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

3 participants