Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine how to handle the 'proof' parameter for queries to the private store #205

Closed
andynog opened this issue Aug 13, 2020 · 1 comment · Fixed by #318
Closed

Determine how to handle the 'proof' parameter for queries to the private store #205

andynog opened this issue Aug 13, 2020 · 1 comment · Fixed by #318
Labels
A: question Admin: further information is requested I: CLI Internal: related to the relayer's CLI I: logic Internal: related to the relaying logic
Milestone

Comments

@andynog
Copy link
Contributor

andynog commented Aug 13, 2020

In a discussion in #196, it was brought up the fact that some queries such as clients/{identifier}/connections that target the private store allows the proof parameter to be specified. The discussion was that if we need to set (hardcode) this parameter to false since we know that is the only valid value or if we should allow users to specify an invalid value (e.g. true) and get an error message (right now an error client connections query error store error: requested proof for privateStore path is shown). This is affects other queries too e.g. clients/{identifier}/clientState.

This is a UX decision too, need to think the best way to refactor the code for this. Hardcoding the value to false in these use cases is the quick solution, but there might be a need eventually some architecture decisions (e.g. know if the query targets a private or provable store and handle accordingly).

Reference: https://github.com/cosmos/ics/tree/master/spec/ics-024-host-requirements

@andynog andynog added A: question Admin: further information is requested I: CLI Internal: related to the relayer's CLI I: logic Internal: related to the relaying logic labels Aug 13, 2020
@ancazamfir ancazamfir added this to the v.0.0.3 milestone Aug 14, 2020
@ebuchman ebuchman modified the milestones: v.0.0.3, v0.0.4, v0.0.7 Aug 20, 2020
@ancazamfir
Copy link
Collaborator

Let's remove the -p option from QueryClientConnectionsCmd as there is no benefit to it, especially that the default is true which fails the query immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: question Admin: further information is requested I: CLI Internal: related to the relayer's CLI I: logic Internal: related to the relaying logic
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants