Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify Hermes retry pending tx behavior with an end-to-end test #2074

Closed
6 tasks
seanchen1991 opened this issue Apr 6, 2022 · 1 comment
Closed
6 tasks
Assignees
Labels
I: logic Internal: related to the relaying logic O: tests Objective: Test more aspect of the relayer
Milestone

Comments

@seanchen1991
Copy link
Contributor

Summary

Verify the fix implemented in #1951 with an end-to-end test.

Problem Definition

The behavior that #1951 addresses leads to subtle issues around pending tx resubmission that are difficult to debug. While the implemented fix has been tested manually, more rigorous testing would be helpful.

Proposal

Add an end-to-end test that verifies that the retrying mechanism for pending txs resubmits regenerated messages and not stale ones.

Acceptance Criteria


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@seanchen1991 seanchen1991 self-assigned this Apr 6, 2022
@romac romac added I: logic Internal: related to the relaying logic O: tests Objective: Test more aspect of the relayer labels Apr 13, 2022
@romac romac added this to the v0.15.0 milestone Apr 13, 2022
@adizere adizere modified the milestones: v0.15.0, v1.0.0 May 24, 2022
@seanchen1991
Copy link
Contributor Author

seanchen1991 commented Jun 6, 2022

Closing this issue as #1951 addresses it by including an integration test for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: logic Internal: related to the relaying logic O: tests Objective: Test more aspect of the relayer
Projects
No open projects
Status: Closed
Development

No branches or pull requests

3 participants