Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for selecting specific wallet for packet clearing CLI #2111

Closed
3 of 6 tasks
adizere opened this issue Apr 21, 2022 · 2 comments · Fixed by #2252
Closed
3 of 6 tasks

Add support for selecting specific wallet for packet clearing CLI #2111

adizere opened this issue Apr 21, 2022 · 2 comments · Fixed by #2252
Assignees
Labels
I: CLI Internal: related to the relayer's CLI O: usability Objective: cause to improve the user experience (UX) and ease using the product
Milestone

Comments

@adizere
Copy link
Member

adizere commented Apr 21, 2022

Summary

Add -k <KEY> option for clear packets CLI, just like Hermes provides one for tx raw ft-transfer -k <KEY>

Problem Definition

Hermes operators typically run one start instance in the background and then sometimes require a second instance to do packet clearing in parallel. This second instance should not be reusing the same wallet as the first, otherwise it would result in account sequence mismatch errors. Currently, it is not possible to start clear packets with a separate wallet.

Acceptance Criteria

  • Add support for using a specific with option -k as part of clear packets CLI

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added I: CLI Internal: related to the relayer's CLI O: usability Objective: cause to improve the user experience (UX) and ease using the product P-medium labels Apr 21, 2022
@adizere adizere added this to the v0.15.0 milestone Apr 21, 2022
@adizere adizere modified the milestones: v0.15.0, v1.0.0 May 24, 2022
@seanchen1991
Copy link
Contributor

I'm not sure what a key looks like. What's an example key I could use to test this flow?

@ancazamfir
Copy link
Collaborator

I think we should have the -k for all CLIs. Is there a way to have a generic solution for all CLIs? i.e. overwrite the key in the chain config if -k flag is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: CLI Internal: related to the relayer's CLI O: usability Objective: cause to improve the user experience (UX) and ease using the product
Projects
No open projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

3 participants