Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple chain types in the configuration #2240

Closed
5 tasks
Tracked by #1630
romac opened this issue May 24, 2022 · 0 comments · Fixed by #2228
Closed
5 tasks
Tracked by #1630

Add support for multiple chain types in the configuration #2240

romac opened this issue May 24, 2022 · 0 comments · Fixed by #2228
Assignees
Labels
E: non-cosmos External: related to non-Cosmos chains
Milestone

Comments

@romac
Copy link
Member

romac commented May 24, 2022

Summary

Add support for multiple chain types in the configuration.

Problem Definition

We will eventually need to enable support for non-Cosmos chains or for variations on Cosmos chains (eg. for chains with the psql indexer enabled).

A first step towards this would be to add a chain_type field to the ChainConfig which specifies what kind of chain runtime to instantiate.

Proposal

Add a chain_type: ChainType field to the ChainConfig and inspect its value to decide which chain endpoint implementation to instantiate.

Acceptance Criteria

Setting chain_type = 'CosmosSdk' in the config does not raise an error and instantiates a CosmosSdkChain in all commands (start included).


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@romac romac added the E: non-cosmos External: related to non-Cosmos chains label May 24, 2022
@romac romac added this to the v1.0.0 milestone May 24, 2022
@romac romac self-assigned this May 24, 2022
@romac romac assigned romac and unassigned romac Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E: non-cosmos External: related to non-Cosmos chains
Projects
No open projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

1 participant