Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out trust threshold values less than 1/3 and greater than 2/3 #2798

Closed
4 of 7 tasks
seanchen1991 opened this issue Nov 1, 2022 · 0 comments · Fixed by #2839
Closed
4 of 7 tasks

Filter out trust threshold values less than 1/3 and greater than 2/3 #2798

seanchen1991 opened this issue Nov 1, 2022 · 0 comments · Fixed by #2839
Assignees
Labels
I: logic Internal: related to the relaying logic O: new-feature Objective: cause to add a new feature or support O: usability Objective: cause to improve the user experience (UX) and ease using the product
Milestone

Comments

@seanchen1991
Copy link
Contributor

seanchen1991 commented Nov 1, 2022

Summary

Filter out trust threshold values less than 1/3 and greater than 2/3 to better cater to relaying use-cases that require trust threshold values other than 1/3.

Problem Definition

Building off of the issue outlined in #2746, where packets were not being relayed due to a trust threshold of 1/2 (currently, Hermes crudely requires a threshold of 1/3), Hermes should filter out messages relayed with a trust threshold lower than 1/3 (for security reasons) and greater than 2/3 (for cost-efficiency reasons). This would better cater to relaying use-cases that require a trust threshold other than 1/3.

Proposal

Remove the current hard-coded trust threshold of 1/3 and replace it with a bounds check that ensures that the user's trust threshold is configured to be between 1/3 and 2/3.

These values are sensible defaults, but will still be hard-coded for the time being. In the case where users feel it would be beneficial for these bounds to be configurable, we will address that in a future PR.

Acceptance Criteria

  • Hermes filters out trust thresholds below 1/3 and greater than 2/3.
  • Add an integration test testing the client filter functionality.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@seanchen1991 seanchen1991 self-assigned this Nov 1, 2022
@seanchen1991 seanchen1991 added O: new-feature Objective: cause to add a new feature or support I: logic Internal: related to the relaying logic O: usability Objective: cause to improve the user experience (UX) and ease using the product P-medium labels Nov 1, 2022
@seanchen1991 seanchen1991 added this to the v1.2 milestone Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: logic Internal: related to the relaying logic O: new-feature Objective: cause to add a new feature or support O: usability Objective: cause to improve the user experience (UX) and ease using the product
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant