Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner context mocks for ICS18 and ICS26 #297

Closed
6 tasks done
adizere opened this issue Oct 8, 2020 · 0 comments · Fixed by #310
Closed
6 tasks done

Cleaner context mocks for ICS18 and ICS26 #297

adizere opened this issue Oct 8, 2020 · 0 comments · Fixed by #310
Assignees
Labels
O: code-hygiene Objective: cause to improve code hygiene O: tests Objective: Test more aspect of the relayer
Milestone

Comments

@adizere
Copy link
Member

adizere commented Oct 8, 2020

Summary

The last bits as part of overhauling mock context cosmos/ibc-rs#111: this issue addresses specifically the mock context for ICS18 and ICS26. Once we clean these up, we will also be able to remove the old context mocks (MockConnectionContext, MockClientContext)

@ancazamfir raised two interesting comments while reviewing the prior iteration of work on mock contexts:

Wondering if we should check for sanity for the context, even if it's mock, just to make sure the tests don't initialize with a bad context. For example check that the client of a connection is present. Could also add the connection to client here.
I am also wondering if we should allow for a vector of connections, i.e. call it with_connections().

TODOs:

  • Anca's two suggestions
  • modules/src/ics03_connection/handler.rs the context should not be mutable

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added O: tests Objective: Test more aspect of the relayer O: code-hygiene Objective: cause to improve code hygiene labels Oct 8, 2020
@adizere adizere added this to the v0.0.5 milestone Oct 8, 2020
@adizere adizere self-assigned this Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: code-hygiene Objective: cause to improve code hygiene O: tests Objective: Test more aspect of the relayer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant