Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hermes query client consensus does not sort the consensus states by height #3041

Closed
1 of 5 tasks
ancazamfir opened this issue Jan 26, 2023 · 0 comments · Fixed by #3044
Closed
1 of 5 tasks

Hermes query client consensus does not sort the consensus states by height #3041

ancazamfir opened this issue Jan 26, 2023 · 0 comments · Fixed by #3044
Assignees
Labels
A: bug Admin: something isn't working A: good-first-issue Admin: good for newcomers A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews
Milestone

Comments

@ancazamfir
Copy link
Collaborator

ancazamfir commented Jan 26, 2023

Summary of Bug

hermes query client consensus does not sort the consensus states by height value.

Version

master

Steps to Reproduce

Use hermes update client with --height and --trusted-height to create a few consensus states, then query. The result will be something like:

$ hermes --config config.toml query client consensus --chain ibc-0 --client 07-tendermint-0
2023-01-26T18:45:43.483534Z  INFO ThreadId(01) running Hermes v1.2.0+52b78c41-dirty
SUCCESS [
    Height {
        revision: 1,
        height: 1000,
    },
    Height {
        revision: 1,
        height: 18814,
    },
    Height {
        revision: 1,
        height: 2558,
    },
    Height {
        revision: 1,
        height: 577,
    },
...

Acceptance Criteria

CLI should list the consensus states in height order


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ancazamfir ancazamfir added A: bug Admin: something isn't working A: good-first-issue Admin: good for newcomers A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews labels Jan 26, 2023
@ancazamfir ancazamfir added this to the v1.5 milestone Jan 26, 2023
@romac romac self-assigned this Jan 27, 2023
@romac romac modified the milestones: v1.5, v1.4 Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working A: good-first-issue Admin: good for newcomers A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants