Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metric for skipped client update messages #3707

Closed
5 tasks
ljoss17 opened this issue Nov 24, 2023 · 0 comments · Fixed by #3706
Closed
5 tasks

Add metric for skipped client update messages #3707

ljoss17 opened this issue Nov 24, 2023 · 0 comments · Fixed by #3706
Assignees
@ljoss17
Labels
I: telemetry Internal: related to Telemetry & metrics

Comments

@ljoss17
Copy link
Contributor

ljoss17 commented Nov 24, 2023

Summary

Hermes v1.7.1 introduced a new feature which skips sending client updates if the consensus state already exists, #3555.

Introducing a new metric counting the number of skipped client update with this feature could help assess the effectiveness.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ljoss17 ljoss17 added the I: telemetry Internal: related to Telemetry & metrics label Nov 24, 2023
@ljoss17 ljoss17 self-assigned this Nov 24, 2023
@ljoss17 ljoss17 mentioned this issue Nov 24, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljoss17 ljoss17

Labels
I: telemetry Internal: related to Telemetry & metrics
Projects
Hermes
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add metric to count skipped client update messages informalsystems/hermes
1 participant
@ljoss17