Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABCI Merkle Proof struct does not match Go counterpart #198

Closed
romac opened this issue Mar 30, 2020 · 3 comments
Closed

ABCI Merkle Proof struct does not match Go counterpart #198

romac opened this issue Mar 30, 2020 · 3 comments

Comments

@romac
Copy link
Member

romac commented Mar 30, 2020

@ancazamfir uncovered what we think is a discrepancy between the way ABCI Merkle proofs are represented in this crate vs the Go implementation.

The AbciQuery datatype into which ABCI responses are deserialized* carries an optional Proof, which is defined in this crate as a wrapper around a bytevector serialized as a hex-encoded string, whereas the corresponding struct in the Go code is defined as an actual struct with proof ops etc.

It is thus currently not possible to properly deserialize the result of ABCI queries when those carry a proof, as shown in the tests Anca included in her PR implementing a consensus state query for ibc-rs.

* We should perhaps find a better name for that struct, since it is used both for queries and their responses. Or perhaps the issue stems from the fact that those should be different datatypes?

@tarcieri
Copy link
Contributor

I'm guessing this is another v0.33 incompatibility? (see #184)

@tomtau
Copy link
Contributor

tomtau commented Apr 1, 2020

ABCI Proof was structured that way before 0.33: https://github.com/tendermint/rust-abci/blob/aa163393f139b971f7935ad6afac4f542e1bb016/src/messages/merkle.rs

I guess it should be fine once the types are generated from canonical protobuf definitions
ref: #29 (comment)

@ancazamfir ancazamfir mentioned this issue Apr 7, 2020
5 tasks
@liamsi liamsi mentioned this issue Apr 8, 2020
5 tasks
@ancazamfir
Copy link
Contributor

Fixed in #206, in tendermint/v0.33 branch. Thanks @liamsi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants