Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream integration testing functionality from cosmos-sdk-rs? #944

Closed
tony-iqlusion opened this issue Aug 6, 2021 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@tony-iqlusion
Copy link
Collaborator

#942 (which I'm basically responsible for) seems like the sort of problem which would've been caught easily by a live integration test against a Tendermint RPC endpoint.

I wrote a handful of simple utility functions to assist integration testing against a single-node gaiad as part of cosmos-sdk-rs:

https://github.com/cosmos/cosmos-rust/blob/7ff213318ddc93440bbe6030e8258631b2bd8b59/cosmos-sdk-rs/src/dev.rs

Would there be any interest in upstreaming these to tendermint-rs? It seems useful for e.g. integration testing tendermint-rpc in a way which could run as part of CI.

@tony-iqlusion tony-iqlusion added the enhancement New feature or request label Aug 6, 2021
@thanethomson
Copy link
Contributor

We currently have integration testing against the kvstore in the tools folder, as well as our rpc-probe which we usually use to generate fixtures for the RPC tests (see here).

We just need to generate those fixtures for the /tx endpoint and add an integration test against the kvstore and we'll automatically detect regressions here in CI.

@tony-iqlusion
Copy link
Collaborator Author

Aha, sounds good then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants