Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url crate used by tendermint does not support no_std #985

Closed
Tracked by #1158
soareschen opened this issue Sep 17, 2021 · 3 comments
Closed
Tracked by #1158

url crate used by tendermint does not support no_std #985

soareschen opened this issue Sep 17, 2021 · 3 comments
Labels
no_std no_std compatibility

Comments

@soareschen
Copy link
Contributor

soareschen commented Sep 17, 2021

The struct url::Url is used inside tendermint::net, however the url crate cannot work under no_std. We would have to either move tendermint::net to a separate crate, or find an alternative crate that supports no_std.

Note that the tendermint::net module is not used in any part of the ibc crate. However it is not clear whether it is used indirectly by ibc elsewhere, which would complicate the issue.

There is a recent pending PR in August 2021 to support no_std in url: servo/rust-url#717. However it is not clear when it will get merged. An alternative solution would be to contribute upstream and push for that PR to get merged and released soon.

@seanchen1991
Copy link

Does #986 address the url crate's no_std compliance in any way?

@soareschen
Copy link
Contributor Author

Does #986 address the url crate's no_std compliance in any way?

tendermint-config do not have to be no_std-compliant. Only tendermint crate needs to be, and in this PR we have removed the url dependency in tendermint crate itself.

@soareschen
Copy link
Contributor Author

This has been addressed with the use of Url moved to tendermint-config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no_std no_std compatibility
Projects
None yet
Development

No branches or pull requests

2 participants