Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FromJSON ToJSON instances for config #106

Open
sergey-kintsel opened this issue Mar 30, 2018 · 2 comments
Open

FromJSON ToJSON instances for config #106

sergey-kintsel opened this issue Mar 30, 2018 · 2 comments

Comments

@sergey-kintsel
Copy link

I am thinking maybe it's a good idea to have ready to go instances for json/yml/whateverml so that people would be able to use it in their apps and just put the configs into config/redis.yml or whatever?
There is a solution for that already: https://bitbucket.org/s9gf4ult/hedis-config. But, the problem with it is that it's outdated and doesn't compile with the latest hedis version.
I've created PRs to make it work with latest versions of hedis, but, the author didn't respond to me. So, I am thinking, maybe we could add this thingy right there?

@k-bx
Copy link
Collaborator

k-bx commented Mar 30, 2018

@sergey-kintsel there's a pretty good process for taking over the packages https://wiki.haskell.org/Taking_over_a_package I've used that process few times and it worked flawlessly in all cases.

Regarding adding the instances -- I don't have a strong opinion here, but would lean towards not putting them in, mostly because I think this doesn't solve the configuration problem for a relatively high percentage of users, while forcing them to have the dependencies on the libraries they might not use.

@sergey-kintsel
Copy link
Author

Thanks for the link. I understand your point. I will follow the process and wait until the author responds (or not). Meantime, I will use my version in my projects. Thanks for the quick answer :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants