Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There should be an option to disable UDP proxy #134

Closed
danada opened this issue Oct 1, 2020 · 1 comment
Closed

There should be an option to disable UDP proxy #134

danada opened this issue Oct 1, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@danada
Copy link
Contributor

danada commented Oct 1, 2020

Since the --output-file flag was added to open-stream some use cases will not require the use of the proxy whatsoever. In fact, if a user opens two CLI instances on the same machine with default params, one of the CLIs will crash since the default port will be in use.

Proposal is to:

  • Add none or off option to the --proxy flag
  • Default to UDP in order to not break compatibility
  • When none, simply do not start the proxy
  • If none, ignore all port params
@danada danada added the enhancement New feature or request label Oct 1, 2020
@danada
Copy link
Contributor Author

danada commented Nov 5, 2020

Closed in #137

@danada danada closed this as completed Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danada