Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wording changes #98

Closed
5 tasks done
jwhhh opened this issue Dec 6, 2022 · 0 comments · Fixed by #102
Closed
5 tasks done

Wording changes #98

jwhhh opened this issue Dec 6, 2022 · 0 comments · Fixed by #102
Assignees
Labels
cofi core New feature or refactoring for core api cofi inference tools New feature or refactoring for links to solvers library documentation Improvements or additions to documentation WIP Work in progress

Comments

@jwhhh
Copy link
Member

jwhhh commented Dec 6, 2022

  • the wordings are inconsistent, change all "solvers" into "tools" (in the two suggest_tools method)
  • did you mean 'matrix solvers?' -> did you mean 'matrix solvers'? (move out the question mark)
  • remove the line search reference link in cofi.simple_newton
  • in cofi.simple_newton, change "max_iterations" into "num_iterations" (make sure all existing examples work)
  • shorten error messages (print and raise in some places, instead of raising from)
@jwhhh jwhhh added documentation Improvements or additions to documentation cofi core New feature or refactoring for core api cofi inference tools New feature or refactoring for links to solvers library labels Dec 6, 2022
@jwhhh jwhhh self-assigned this Dec 12, 2022
@jwhhh jwhhh added the WIP Work in progress label Dec 12, 2022
@jwhhh jwhhh mentioned this issue Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cofi core New feature or refactoring for core api cofi inference tools New feature or refactoring for links to solvers library documentation Improvements or additions to documentation WIP Work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant